Skip to content

Capstone v5#3301

Closed
XVilka wants to merge 4 commits intodevfrom
capstone-v5-2
Closed

Capstone v5#3301
XVilka wants to merge 4 commits intodevfrom
capstone-v5-2

Conversation

@XVilka
Copy link
Member

@XVilka XVilka commented Jan 19, 2023 •
edited
Loading

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

An updated version of abandoned #345

I also set the capstone version to the latest 5.0 release candidate: https://github.com/capstone-engine/capstone/releases/tag/5.0-rc2

Test plan

CI is green

See also related #3210

@github-actions github-actions bot added documentation Improvements or additions to documentation infrastructure rz-test labels Jan 19, 2023
@XVilka XVilka mentioned this pull request Jan 19, 2023
Closed
4 tasks
@thestr4ng3r
Copy link
Member

thestr4ng3r commented Jan 19, 2023

Also enable these:

rizin/test/db/asm/arm_32

Line 361 in 907e098

# requires capstone v5:

rizin/test/db/asm/arm_64

Line 467 in 907e098

# Capstone v5 required for these:

@XVilka XVilka mentioned this pull request Jan 27, 2023
Closed
@XVilka
Copy link
Member Author

XVilka commented Apr 14, 2023

@Rot127 assigned to you since it's closely related to the auto-sync work. Feel free to modify/update/etc

@XVilka XVilka mentioned this pull request Apr 23, 2023
Closed
5 tasks
@XVilka
Copy link
Member Author

XVilka commented May 18, 2023

A prerequisite for #3463 to be merged once it's done.

@XVilka
Copy link
Member Author

XVilka commented May 18, 2023

Too many broken things in ARM and PPC. We probably should wait first until all our ARM, PPC, and ARM64 auto-sync pull requests are merged first, before updating the capstone. @imbillow it would mean that to keep the build green, we will have to keep the Tricore work in a separate branch(es) for now and rebase it periodically on top of the latest dev. Once these merged, we could port all our tests to them and migrate to the capstone-next, skipping the v5 version all together.

@Rot127 @wargio @ret2libc @thestr4ng3r thoughts about this?

@wargio
Copy link
Member

wargio commented May 18, 2023 •
edited
Loading

wow, that is indeed very broken
I do prefer the PRs to be merged here and then we can merge (no-squash) to dev later, once everything is green

@Rot127
Copy link
Member

Rot127 commented May 18, 2023 •
edited
Loading

Once these merged, we could port all our tests to them and migrate to the capstone-next, skipping the v5 version all together.

This would effectively mean to skip CS v5 in favor of CS v5.1 (or whatever it might be named)?

I am very in favor of this!

@wargio wargio deleted the capstone-v5-2 branch January 2, 2026 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wargio wargio Awaiting requested review from wargio wargio is a code owner

@kazarmy kazarmy Awaiting requested review from kazarmy kazarmy is a code owner

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r is a code owner

@ret2libc ret2libc Awaiting requested review from ret2libc ret2libc is a code owner

@yossizap yossizap Awaiting requested review from yossizap

Assignees

@b1llow b1llow

@Rot127 Rot127

Labels

capstone documentation Improvements or additions to documentation high-priority infrastructure rz-test

Projects

None yet

Milestone

0.7.0

Development

Successfully merging this pull request may close these issues.

6 participants

@XVilka @thestr4ng3r @wargio @Rot127 @b1llow @yossizap